Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module cloud.google.com/go/spanner to v1.73.0 #36685

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

manu2
Copy link
Contributor

@manu2 manu2 commented Dec 4, 2024

Fixing failed renovate PR : #36317

@manu2 manu2 requested review from dashpole and a team as code owners December 4, 2024 21:14
@dashpole dashpole added the dependencies Pull requests that update a dependency file label Dec 4, 2024
@manu2 manu2 changed the title Update module cloud.google.com/go/spanner to v1.72.0 Update module cloud.google.com/go/spanner to v1.73.0 Dec 5, 2024
@manu2
Copy link
Contributor Author

manu2 commented Dec 5, 2024

Fix was added in a later version googleapis/google-cloud-go#11109
So upgrading to v1.73.0 solves the failures.

Tested workflow run on fork repo: https://github.com/manu2/opentelemetry-collector-contrib/actions/runs/12176565177/job/33963284985?pr=1

@dashpole
Copy link
Contributor

dashpole commented Dec 5, 2024

go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

@manu2
Copy link
Contributor Author

manu2 commented Dec 5, 2024

Ran go mod tidy -compat=1.22.0 in opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver. Added commit.

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Dec 5, 2024
@evan-bradley evan-bradley merged commit 73b7011 into open-telemetry:main Dec 6, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 6, 2024
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready to merge Code review completed; ready to merge by maintainers receiver/googlecloudspanner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants