Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/ottl] Add additional new function guidelines #36696

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[chore][pkg/ottl] Add additional new function guidelines #36696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/ottl/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ Your proposal likely will be accepted if:
- The proposed functionality is missing,
- The proposed solution significantly improves user experience and readability for very common use cases,
- The proposed solution is more performant in cases where it is possible to achieve the same result with existing options.
- The proposed solution makes use of packages from the Go standard library to offer functionality possible through an existing option in a more standard or reliable manner.

It will be up for discussion if your proposal solves an issue that can be achieved in another way but does not improve user experience or performance.
It will be up for discussion if:

- Your proposal solves an issue that can be achieved in another way but does not improve user experience or performance.
- The proposed functionality is not obviously applicable to the needs of a significant number of OTTL users.
- Your proposal extracts data into a structure with enumerable keys or values and OpenTelemetry semantic conventions do not cover the shape or values for this data.

Your proposal likely won't be accepted if:

Expand Down
Loading