[receiver/libhoney] New receiver for libhoney #36706
Conversation
|
sorry for the noise @bogdandrutu with all the rebuilds. Was having some trouble with the linter running locally and had to rely on CI 😬 This is just the scaffolding for the new receiver. Is there anything else to do on this PR? |
mterhar
force-pushed
the
new-libhoney-receiver
branch
from
bf5729f to
d987e08
Compare
mterhar
force-pushed
the
new-libhoney-receiver
branch
from
d987e08 to
78f21aa
Compare
| return nil | ||
| } | ||
|
|
||
| if r.nextTraces != nil { |
There was a problem hiding this comment.
not sure if this log is needed here
There was a problem hiding this comment.
I just needed something there so it wouldn't complain about a useless if statement. It'll be removed when the handler code is added.
| }, | ||
| AuthAPI: "", | ||
| Resources: ResourcesConfig{ | ||
| ServiceName: "service.name", |
There was a problem hiding this comment.
could these strings be pulled from semconv packages?
There was a problem hiding this comment.
The point of these is to be able to map non-semconv service name strings into a the semconv named string.
The use of service.name here as a default is just because people may have already changed their service name fields to match what OTEL uses and we want to honor that unless they want to configure an override.
receiver/libhoneyreceiver/internal/sharedcomponent/sharedcomponent.go
Outdated
Show resolved
Hide resolved
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Creates a new receiver that accepts libhoney traffic as either logs or traces. This PR doesn't do the conversion yet. Just contains configurations and some factory components. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#36693
Description
Creates a new receiver that accepts libhoney traffic as either logs or traces.
This PR doesn't do the conversion yet. Just contains configurations and some factory components.
Link to tracking issue
#36693