[chore] Fix TestPerfCounter_Reset test #36726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Dec 9, 2024
|
@codeboten I would love to have |
atoulme
approved these changes
Dec 9, 2024
dmitryax
approved these changes
Dec 9, 2024
CI failures:Windows failures are #36481 OPAMP failure: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12242789600/job/34151180181?pr=36726#step:8:823
|
|
Thanks @pjanotti! |
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description
Fix the TestPerfCounter_Reset that is failing consistently.
```terminal
=== FAIL: . TestPerfCounter_Reset (0.00s)
watcher_test.go:131:
Error Trace: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/winperfcounters/watcher_test.go:131
Error: Both arguments must be pointers
Test: TestPerfCounter_Reset
```
Root case: after upgrading `testify` circa of 2 weeks ago, since it
included:
> NotSame should fail if args are not pointers
stretchr/testify#1661 by @sikehish in
stretchr/testify#1664
See https://github.com/stretchr/testify/releases
#### Testing
Local test run
Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the TestPerfCounter_Reset that is failing consistently.
Root case: after upgrading
testifycirca of 2 weeks ago, since it included:See https://github.com/stretchr/testify/releases
Testing
Local test run