Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update otel #36728

Merged
merged 4 commits into from
Dec 9, 2024
Merged

[chore] Update otel #36728

merged 4 commits into from
Dec 9, 2024

Conversation

TylerHelmuth
Copy link
Member

No description provided.

@@ -52,7 +52,6 @@ func GenerateProfilesTwoProfilesSameResource() pprofile.Profiles {

func fillProfileOne(profile pprofile.Profile) {
profile.SetStartTime(TestProfileStartTimestamp)
profile.SetEndTime(TestProfileEndTimestamp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is end time no longer needed?

Copy link
Member Author

@TylerHelmuth TylerHelmuth Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function was removed in open-telemetry/opentelemetry-collector#11796 so hopefully its no longer needed

@codeboten codeboten merged commit c1eaf7f into open-telemetry:main Dec 9, 2024
159 of 160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 9, 2024
@TylerHelmuth TylerHelmuth deleted the update-otel branch December 9, 2024 18:34
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants