Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back "[exporter/awsemfexporter]Split EMF log with larger than 100 buckets." #36771

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

zzhlogin
Copy link
Contributor

Description

This PR fix the flaky unit test in previous PR: #36336, and add back the implementation of splitting the emf log logic.

Link to tracking issue

#36727

Testing

Unit test updated and passed with 10 count:

go test -run TestAddToGroupedMetric -count 10 -tags=always

PASS
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter	0.016s

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mx-psi mx-psi merged commit a70fa09 into open-telemetry:main Dec 17, 2024
160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 17, 2024
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this pull request Dec 19, 2024
… buckets." (open-telemetry#36771)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR fix the flaky unit test in previous PR:
open-telemetry#36336,
and add back the implementation of splitting the emf log logic.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

open-telemetry#36727

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit test updated and passed with 10 count:
```
go test -run TestAddToGroupedMetric -count 10 -tags=always

PASS
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter	0.016s

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/awsemf awsemf exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants