[receiver/awss3receiver] Add support RFC3339 format for starttime and endtime #36787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for quick review! I've added a file under .chloggen. Changes are here 🙇 |
SpencerTorres
approved these changes
Dec 12, 2024
atoulme
added
the
ready to merge
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
… endtime (open-telemetry#36787) #### Description This PR adds support RFC3339 (`"2006-01-02T15:04:05Z07:00"`) format for `starttime` and `endtime` fields. Currently, those fields cannot specify timezone. It's depends on the situation. This change makes clear the timezone. #### Testing This PR adds a new test data `awss3/4` which tests specifying RFC3339.
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
… endtime (open-telemetry#36787) #### Description This PR adds support RFC3339 (`"2006-01-02T15:04:05Z07:00"`) format for `starttime` and `endtime` fields. Currently, those fields cannot specify timezone. It's depends on the situation. This change makes clear the timezone. #### Testing This PR adds a new test data `awss3/4` which tests specifying RFC3339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support RFC3339 (
"2006-01-02T15:04:05Z07:00") format forstarttimeandendtimefields.Currently, those fields cannot specify timezone. It's depends on the situation.
This change makes clear the timezone.
Testing
This PR adds a new test data
awss3/4which tests specifying RFC3339.Documentation
This PR changes README.md to describe time format.