Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: use testify instead of testing.Fatal or testing.Error in exporter #36835

Merged
merged 1 commit into from
Dec 14, 2024
Merged

[chore]: use testify instead of testing.Fatal or testing.Error in exporter #36835

merged 1 commit into from
Dec 14, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

  • uses testify instead of testing.Fatal or testing.Error in processor

@mmorel-35 mmorel-35 force-pushed the testifier/exporter branch 3 times, most recently from 8ac172d to 274ef3f Compare December 14, 2024 15:32
@mmorel-35 mmorel-35 force-pushed the testifier/exporter branch 4 times, most recently from 05ab950 to bbdd281 Compare December 14, 2024 16:27
@mmorel-35 mmorel-35 marked this pull request as ready for review December 14, 2024 16:42
@mmorel-35 mmorel-35 requested a review from a team as a code owner December 14, 2024 16:42
@mmorel-35 mmorel-35 force-pushed the testifier/exporter branch 4 times, most recently from 5b0d0e9 to def2e53 Compare December 14, 2024 18:09
@github-actions github-actions bot requested a review from erichsueh3 December 14, 2024 18:09
dmitryax
dmitryax approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the improvements!

@dmitryax dmitryax merged commit 02ef19a into open-telemetry:main Dec 14, 2024
160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 14, 2024
@mmorel-35 mmorel-35 deleted the testifier/exporter branch December 14, 2024 22:42
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@mmorel-35 @sbylica-splunk
[chore]: use testify instead of testing.Fatal or testing.Error in exp…
949a162 
…orter (open-telemetry#36835)
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this pull request Dec 19, 2024
@mmorel-35 @mterhar
[chore]: use testify instead of testing.Fatal or testing.Error in exp…
d0fe189 
…orter (open-telemetry#36835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@ArthurSens ArthurSens Awaiting requested review from ArthurSens

@billmeyer billmeyer Awaiting requested review from billmeyer

@bryan-aguilar bryan-aguilar Awaiting requested review from bryan-aguilar

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@Frapschen Frapschen Awaiting requested review from Frapschen

@gjanco gjanco Awaiting requested review from gjanco

@hanjm hanjm Awaiting requested review from hanjm

@jade-guiton-dd jade-guiton-dd Awaiting requested review from jade-guiton-dd

@kongluoxing kongluoxing Awaiting requested review from kongluoxing

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@mcube8 mcube8 Awaiting requested review from mcube8

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@mxiamxia mxiamxia Awaiting requested review from mxiamxia

@qiansheng91 qiansheng91 Awaiting requested review from qiansheng91

@rapphil rapphil Awaiting requested review from rapphil

@shabicheng shabicheng Awaiting requested review from shabicheng

@sokoide sokoide Awaiting requested review from sokoide

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@SpencerTorres SpencerTorres Awaiting requested review from SpencerTorres

@yotamloe yotamloe Awaiting requested review from yotamloe

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dao-jun dao-jun Awaiting requested review from dao-jun

@fchikwekwe fchikwekwe Awaiting requested review from fchikwekwe

@gramidt gramidt Awaiting requested review from gramidt

@mar4uk mar4uk Awaiting requested review from mar4uk

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@lquerel lquerel Awaiting requested review from lquerel

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3

@erichsueh3 erichsueh3 Awaiting requested review from erichsueh3

Assignees

@bogdandrutu bogdandrutu

Labels
exporter/alertmanager exporter/alibabacloudlogservice Alibaba components exporter/awsemf awsemf exporter exporter/clickhouse exporter/datadog Datadog components exporter/honeycombmarker exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/otelarrow exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/signalfx exporter/splunkhec extension/sigv4auth
Projects
None yet
Milestone
v0.116.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @dmitryax @bogdandrutu