[chore]: enable partially thelper linter #36836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
connector/exceptions
connector/spanmetrics
exporter/alibabacloudlogservice
github-actions
bot
requested review from
Aneurysm9,
ArthurSens,
atingchen,
bryan-aguilar,
dao-jun,
dashpole,
dmitryax,
fchikwekwe,
Frapschen,
gramidt,
kongluoxing,
mar4uk,
marctc,
mxiamxia,
pcwiese,
portertech,
qiansheng91,
shabicheng and
srprash
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
3 times, most recently
from
048ff13 to
361ced9
Compare
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
2 times, most recently
from
254fc13 to
8eb1c24
Compare
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
3 times, most recently
from
1527756 to
3a8cfb6
Compare
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
from
3a8cfb6 to
ea781aa
Compare
mmorel-35
requested review from
a team,
MovieStoreGuy and
crobert-1
as code owners
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
golangci-lint/thelper
branch
from
ea781aa to
8cb615e
Compare
dmitryax
approved these changes
Dec 14, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thelper detects tests helpers which is not start with t.Helper() method.
This only enables rules for naming and paramter order