Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/gitlab] add tracing via webhook skeleton #36838
base: main
Are you sure you want to change the base?
[receiver/gitlab] add tracing via webhook skeleton #36838
Changes from 4 commits
fa02a81
0d0d28c
dd75bd9
26901eb
c9d5be1
585b7de
ab25785
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you and I have talked about this on the side, but after this contribution goes through and you go through getting added as an OpenTelemetry member, it'd be great to have you added to the list of code owners for this receiver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is my first bigger PR, I wasn't sure if that's already enough to become a member. So I thought I would update the code-owners with a subsequent PR once this one is merged and I became a member.
If I can become a member already now, I'm happy to update the code-owners right away as I plan to own/maintain this component. What are your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, updates in the next Pr sound good! And you can go ahead and open up the community issue to request to join now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking about this for the GitHub receiver as well, but I think this should be converted to
RequiredHeaders
ofmap[string]string
so that a user can set any set of headers that are required. The main one that would be useful for GitLab would beX-Gitlab-Instance
. But if a user has a WAF sitting in front of the receiver (which they should anyway for public traffic) then they can set additional headers of their own choosing.For the other headers listed in the doc, I think we should map these internal to the receiver.