Enhance googlecloudmonitoringreceiver: Add Unit Tests for Metric Conversion and Improve Edge Case Coverage #36846
+1,453
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit tests for validating metric conversion logic in googlecloudmonitoringreceiver - Improved test coverage for edge cases in the receiver component
scaletech-milan
requested review from
dashpole,
TylerHelmuth and
a team
as code owners
|
dashpole
reviewed
Dec 16, 2024
- Update testify error handling code - Add sample serviceAccount.json inside testdata
|
Updated all the changes |
|
Looks good. Just needs the CLA signed, and I think we are good to go |
i already proceed for CLA sign, waiting for approval. |
|
Ah, looks like there are linter failures: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12367918994/job/34537235029?pr=36846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added comprehensive test cases for the entire Google Cloud Monitoring Receiver component.
Link to tracking Issue:
#36815
Testing:
Implemented test cases to validate:
Documentation:
N/A