Added HEC error messages #36871
Open
Added HEC error messages #36871
+93
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to close the previous PR because of messy commit history, so reopening here. |
atoulme
reviewed
Dec 17, 2024
| // Check if there is any error text returned by Splunk that we can append to the error message | ||
| if resp.ContentLength > 0 { | ||
| var jsonResponse map[string]any | ||
| bodyString, _ := io.ReadAll(resp.Body) |
There was a problem hiding this comment.
Suggested change
| bodyString, _ := io.ReadAll(resp.Body) | |
| body, _ := io.ReadAll(resp.Body) |
https://pkg.go.dev/io#ReadAll returns a byte array, bodyString is misleading, this is not a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Errors returned from Splunk HEC will be displayed in logs. This will help discover some issues without extensive debugging.
Testing
Unit testing and manual testing of the feature