Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] use v8 client, drop support for EOL versions of ES #37333

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

axw
Copy link
Contributor

@axw axw commented Jan 20, 2025

Description

Update to go-elasticsearch v8, which breaks support for older versions of Elasticsearch v7. The non-EOL v7.17.x versions of Elasticsearch are still supported by the exporter. Add an explicit statement to the README that EOL versions are not supported by the exporter.

Updating to the v8 client allows us to turn on OTel tracing instrumentation for the go-elasticsearch client.

Link to tracking issue

Closes #32454

Testing

  • Tested with 8.latest, confirmed working
  • Tested with 7.17.lasted, confirmed working
  • Tested with 7.10 (EOL), confirmed that it fails with an error message:

2025-02-05T13:23:42.788+0800 error elasticsearchexporter/bulkindexer.go:337 bulk indexer flush error {"kind": "exporter", "data_type": "metrics", "name": "elasticsearch", "error": "failed to execute the request: the client noticed that the server is not Elasticsearch and we do not support this unknown product"}

(7.10 predates the product check protocol that was added to go-elasticsearch v8.)

Documentation

Updated README.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 4, 2025
Drop support for EOL versions of Elasticsearch.
Add an explicit statement to the README that EOL
versions are not supported by the exporter.

Now that we're using v8, turn on OTel tracing
instrumentation for the go-elasticsearch client.
@github-actions github-actions bot removed the Stale label Feb 5, 2025
@axw axw force-pushed the elasticsearchexporter-goelasticsearchv8-breaking branch from 21a3ae1 to 3541660 Compare February 5, 2025 05:25
@axw axw marked this pull request as ready for review February 5, 2025 05:27
@axw axw requested a review from a team as a code owner February 5, 2025 05:27
@axw axw requested a review from fatsheep9146 February 5, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/elasticsearch] Support both v7 and v8 elasticsearch clients and default to v8
5 participants