Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Add OTTL support for profiles #37574

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[pkg/ottl] Add OTTL support for profiles #37574

wants to merge 1 commit into from

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Jan 29, 2025 •
edited
Loading

Fixes #36104

@rockdaboot rockdaboot force-pushed the ottl-profile branch 4 times, most recently from cd7d67e to 7a7b0dc Compare January 31, 2025 17:39
@rockdaboot rockdaboot changed the title Add minimal support of OTTL for profiles [pkg/ottl] Add support of OTTL for profiles Jan 31, 2025
@rockdaboot rockdaboot changed the title [pkg/ottl] Add support of OTTL for profiles [pkg/ottl] Add OTTL support for profiles Jan 31, 2025
@rockdaboot rockdaboot force-pushed the ottl-profile branch 3 times, most recently from 594f736 to a629ef0 Compare February 4, 2025 10:28
dmathieu
dmathieu reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of very similar code. But maybe that's how OTTL does things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu left review comments

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@edmocosta edmocosta Awaiting requested review from edmocosta

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pkg/ottl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] Add support for profiles
2 participants
@rockdaboot @dmathieu