Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Expose source provider #37668

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[exporter/datadog] Expose source provider #37668

wants to merge 8 commits into from

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Feb 4, 2025 •
edited
Loading

Description

This PR moves hostmetadata, clientutil and scrub out of datadogexporter into pkg/datadog. clientutil and scrub were moved because hostmetadata relies on it. hostmetadata was moved because it needs to be imported in agent.

The packages were kept under an internal folder, but there are new packages which exposes the functions needed from outside:

  • github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/hostmetadata => github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/internal/hostmetadata
  • github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/clientutil => github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/internal/clientutil
  • github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/scrub => github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/internal/scrub

Link to tracking issue

Fixes

Testing

Documentation

@mackjmr mackjmr requested review from mx-psi, songy23 and a team as code owners February 4, 2025 10:30
@github-actions github-actions bot added the exporter/datadog Datadog components label Feb 4, 2025
@songy23
Copy link
Member

songy23 commented Feb 4, 2025

This warrants an API changelog too

@mackjmr
Copy link
Member Author

mackjmr commented Feb 5, 2025

CI failures will be solved once #37499 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 left review comments

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@IbraheemA IbraheemA Awaiting requested review from IbraheemA

@jade-guiton-dd jade-guiton-dd Awaiting requested review from jade-guiton-dd

@liustanley liustanley Awaiting requested review from liustanley

At least 1 approving review is required to merge this pull request.

Assignees

@ChrsMark ChrsMark

Labels
connector/datadog exporter/datadog Datadog components pkg/datadog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mackjmr @songy23 @ChrsMark