lokiexporter: support serialization of all body types into JSON
#6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gillg, are you interested in taking a look at this as well? |
jpkrohling
changed the title
lokiexporter: support serialization of all body types into JSON
jpkrohling
approved these changes
Dec 10, 2021
gillg
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Very happy to see this improvement ! I was completly lost on how to return a consistent string type and create fake data for tests when I tried it !
Many thanks for this very fast improvement. I think now lokiexporter can fully handle any OTEL log entry !
The only anoying thing is how to extract a body attribute (in case of map body, like generated by syslogreceiver) to a loki label, but it's more a missing logprocessor to be able moving attributes from body to otel attributes or resources I think.
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
…ts (#6639) Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5846 added support for encoding log entries as json but only worked if the Body was a string.
This expands that all supported types.