Skip to content

Commit

Permalink
Remove warning when 0.0.0.0 is used
Browse files Browse the repository at this point in the history
Signed-off-by: ChrsMark <[email protected]>
  • Loading branch information
ChrsMark committed Dec 16, 2024
1 parent 8ac40a0 commit 9ccbba9
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 177 deletions.
25 changes: 25 additions & 0 deletions .chloggen/remove_net_interface_warn.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: otelcol

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: This PR removes the warning when 0.0.0.0 is used

# One or more tracking issues or pull requests related to the change
issues: [11713, 8510]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
6 changes: 0 additions & 6 deletions config/configgrpc/configgrpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ import (
"go.opentelemetry.io/collector/config/configopaque"
"go.opentelemetry.io/collector/config/configtelemetry"
"go.opentelemetry.io/collector/config/configtls"
"go.opentelemetry.io/collector/config/internal"
"go.opentelemetry.io/collector/extension/auth"
)

Expand Down Expand Up @@ -404,11 +403,6 @@ func (gss *ServerConfig) getGrpcServerOptions(
settings component.TelemetrySettings,
extraOpts []ToServerOption,
) ([]grpc.ServerOption, error) {
switch gss.NetAddr.Transport {
case confignet.TransportTypeTCP, confignet.TransportTypeTCP4, confignet.TransportTypeTCP6, confignet.TransportTypeUDP, confignet.TransportTypeUDP4, confignet.TransportTypeUDP6:
internal.WarnOnUnspecifiedHost(settings.Logger, gss.NetAddr.Endpoint)
}

var opts []grpc.ServerOption

if gss.TLSSetting != nil {
Expand Down
3 changes: 0 additions & 3 deletions config/confighttp/confighttp.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
"go.opentelemetry.io/collector/config/configopaque"
"go.opentelemetry.io/collector/config/configtelemetry"
"go.opentelemetry.io/collector/config/configtls"
configinternal "go.opentelemetry.io/collector/config/internal"
"go.opentelemetry.io/collector/extension/auth"
)

Expand Down Expand Up @@ -407,8 +406,6 @@ func WithDecoder(key string, dec func(body io.ReadCloser) (io.ReadCloser, error)

// ToServer creates an http.Server from settings object.
func (hss *ServerConfig) ToServer(_ context.Context, host component.Host, settings component.TelemetrySettings, handler http.Handler, opts ...ToServerOption) (*http.Server, error) {
configinternal.WarnOnUnspecifiedHost(settings.Logger, hss.Endpoint)

serverOpts := &toServerOptions{}
serverOpts.Apply(opts...)

Expand Down
1 change: 0 additions & 1 deletion config/internal/Makefile

This file was deleted.

19 changes: 0 additions & 19 deletions config/internal/go.mod

This file was deleted.

29 changes: 0 additions & 29 deletions config/internal/go.sum

This file was deleted.

14 changes: 0 additions & 14 deletions config/internal/package_test.go

This file was deleted.

48 changes: 0 additions & 48 deletions config/internal/warning.go

This file was deleted.

57 changes: 0 additions & 57 deletions config/internal/warning_test.go

This file was deleted.

0 comments on commit 9ccbba9

Please sign in to comment.