[chore] call npm with ci instead of install (#11970)

This is as recommended to address a warning about pinning npm install documented in ossf/scorecard#4422 Signed-off-by: Alex Boten <[email protected]>
open-telemetry · Dec 21, 2024 · a573bc9 · a573bc9
1 parent 7c26397
commit a573bc9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
@@ -79,7 +79,7 @@ jobs:
       - name: Render .chloggen changelog entries
         run: make chlog-preview > changelog_preview.md
       - name: Install markdown-link-check
-        run: npm install
+        run: npm ci
       - name: Run markdown-link-check
         run: |
           npx --no -- markdown-link-check \

diff --git a/.github/workflows/check-links.yaml b/.github/workflows/check-links.yaml
@@ -29,13 +29,13 @@ jobs:
       - name: Get changed files
         id: changes
         run: |
-            files=$(git diff --name-only --diff-filter=ACMRTUXB $(git merge-base origin/main $PR_HEAD) $PR_HEAD | grep .md$ | xargs)
-            
-            if [ -z "$files" ] && git diff --name-only $(git merge-base origin/main $PR_HEAD) $PR_HEAD | grep -q "package.json"; then
-              files="**/*.md"
-            fi
+          files=$(git diff --name-only --diff-filter=ACMRTUXB $(git merge-base origin/main $PR_HEAD) $PR_HEAD | grep .md$ | xargs)
 
-            echo "files=$files" >> $GITHUB_OUTPUT
+          if [ -z "$files" ] && git diff --name-only $(git merge-base origin/main $PR_HEAD) $PR_HEAD | grep -q "package.json"; then
+            files="**/*.md"
+          fi
+
+          echo "files=$files" >> $GITHUB_OUTPUT
   check-links:
     runs-on: ubuntu-latest
     needs: changedfiles
@@ -47,12 +47,12 @@ jobs:
           fetch-depth: 0
 
       - name: Install markdown-link-check
-        run: npm install
+        run: npm ci
 
       - name: Run markdown-link-check
         run: |
           npx --no -- markdown-link-check \
             --verbose \
             --config .github/workflows/check_links_config.json \
             ${{needs.changedfiles.outputs.files}} \
-            || { echo "Check that anchor links are lowercase"; exit 1; }
+            || { echo "Check that anchor links are lowercase"; exit 1; }