Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more coverage to mdatagen #11219

Closed
atoulme opened this issue Sep 19, 2024 · 2 comments · Fixed by #11352
Closed

Add more coverage to mdatagen #11219

atoulme opened this issue Sep 19, 2024 · 2 comments · Fixed by #11352

Comments

@atoulme
Copy link
Contributor

atoulme commented Sep 19, 2024

We should add more tests, for example by templating a connector.

          LGTM. Your move of the code from main.go to internal/command.go shows we don't have enough test coverage for some of the templating functions, something we can spin into a new issue.

Originally posted by @atoulme in #11196 (review)
@atoulme atoulme mentioned this issue Sep 19, 2024
Merged
@narcis96
Copy link
Contributor

narcis96 commented Oct 3, 2024

@atoulme I'm interested in working on this! What do you think ?

@narcis96 narcis96 mentioned this issue Oct 4, 2024
Merged
@narcis96
Copy link
Contributor

narcis96 commented Oct 4, 2024

@bogdandrutu @atoulme PTAL on #11352

codeboten added a commit that referenced this issue Oct 9, 2024
@narcis96 @codeboten
Improve coverage of mdatagen (#11352)
83b18b1 
Bump coverage of _cmd/mdatagen/internal/command.go_ from
[70.40%](https://app.codecov.io/gh/open-telemetry/opentelemetry-collector/commit/b1f38a2960608b1b95e0f13547f0bddeebed1175?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
to
[79.37%](https://app.codecov.io/gh/open-telemetry/opentelemetry-collector/commit/9ff6b2b9ce557f5b3cd3dce4d1e48bd16a56f86d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)

Fixes
#11219

---------

Co-authored-by: Alex Boten <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@narcis96 @codeboten @HongChenTW
Improve coverage of mdatagen (open-telemetry#11352)
1eafebe 
Bump coverage of _cmd/mdatagen/internal/command.go_ from
[70.40%](https://app.codecov.io/gh/open-telemetry/opentelemetry-collector/commit/b1f38a2960608b1b95e0f13547f0bddeebed1175?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
to
[79.37%](https://app.codecov.io/gh/open-telemetry/opentelemetry-collector/commit/9ff6b2b9ce557f5b3cd3dce4d1e48bd16a56f86d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)

Fixes
open-telemetry#11219

---------

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve coverage of mdatagen narcis96/opentelemetry-collector
2 participants
@atoulme @narcis96