-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen]: Use cobra for the command, add version flag #11196
[mdatagen]: Use cobra for the command, add version flag #11196
Conversation
a77a269
to
62b9f0d
Compare
62b9f0d
to
244f77d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11196 +/- ##
==========================================
- Coverage 91.83% 91.78% -0.06%
==========================================
Files 415 416 +1
Lines 19856 19869 +13
==========================================
+ Hits 18235 18237 +2
- Misses 1248 1260 +12
+ Partials 373 372 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
244f77d
to
b1f38a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Your move of the code from main.go to internal/command.go shows we don't have enough test coverage for some of the templating functions, something we can spin into a new issue.
Filed #11219 to follow up.
…ry#11196) Signed-off-by: Bogdan Drutu <[email protected]>
No description provided.