Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen]: Use cobra for the command, add version flag #11196

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and dmitryax September 17, 2024 17:18
@bogdandrutu bogdandrutu force-pushed the use-cobra-add-version branch 2 times, most recently from a77a269 to 62b9f0d Compare September 17, 2024 17:21
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 77 lines in your changes missing coverage. Please review.

Project coverage is 91.78%. Comparing base (d5215c5) to head (b1f38a2).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/command.go 70.40% 53 Missing and 21 partials ⚠️
cmd/mdatagen/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11196      +/-   ##
==========================================
- Coverage   91.83%   91.78%   -0.06%     
==========================================
  Files         415      416       +1     
  Lines       19856    19869      +13     
==========================================
+ Hits        18235    18237       +2     
- Misses       1248     1260      +12     
+ Partials      373      372       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Your move of the code from main.go to internal/command.go shows we don't have enough test coverage for some of the templating functions, something we can spin into a new issue.

Filed #11219 to follow up.

@bogdandrutu bogdandrutu merged commit 1edd311 into open-telemetry:main Sep 19, 2024
47 of 49 checks passed
@bogdandrutu bogdandrutu deleted the use-cobra-add-version branch September 19, 2024 18:30
@github-actions github-actions bot added this to the next release milestone Sep 19, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants