Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlphttpreceiver] Allow H2C connections to otlp http receiver #10996

Closed
wants to merge 1 commit into from

Conversation

iblancasa
Copy link
Contributor

Description

Allow H2C connections to otlp http receiver

Fixes #10952

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (70fc33e) to head (66173d4).
Report is 161 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10996   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         455      455           
  Lines       24038    24044    +6     
=======================================
+ Hits        22037    22043    +6     
  Misses       1629     1629           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa iblancasa marked this pull request as ready for review August 30, 2024 13:39
@iblancasa iblancasa requested review from a team and djaglowski August 30, 2024 13:39
@iblancasa iblancasa requested a review from a team as a code owner September 19, 2024 11:07
@iblancasa
Copy link
Contributor Author

@djaglowski could you take a look?

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be opt-in, and have a log warning stating that this is a "weird" configuration. Only very specific setups have a valid reason to have this enabled, such as sidecars terminating TLS right before handing over to the main container.

@iblancasa
Copy link
Contributor Author

Is there anything else pending from this PR?

@iblancasa
Copy link
Contributor Author

Can somebody from @open-telemetry/collector-approvers take a look? Thank you

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I feel bad for introducing new features when we are aiming for v1.

If the Collector approvers decide that this is something we should NOT have for v1, I'd be on their side.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 18, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 5, 2025
Copy link

linux-foundation-easycla bot commented Jan 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: iblancasa / name: Israel Blancas (66173d4)

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Jan 24, 2025
@iblancasa iblancasa closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for http2 connection to otlphttpreceiver for insecure connections
3 participants