Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid public APIs with internal params in custom Options #11054

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and djaglowski September 4, 2024 20:31
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 99.00990% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (64954f4) to head (c10de5d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/common.go 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11054      +/-   ##
==========================================
- Coverage   91.84%   91.82%   -0.03%     
==========================================
  Files         415      415              
  Lines       19850    19905      +55     
==========================================
+ Hits        18232    18278      +46     
- Misses       1245     1252       +7     
- Partials      373      375       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme
Copy link
Contributor

atoulme commented Sep 11, 2024

I think ideally those tests would be tested with a test using a different package name to make sure we can validate the APIs work outside of the module.

@bogdandrutu bogdandrutu merged commit 8027d80 into open-telemetry:main Sep 17, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants