-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove prometheus need to check test metrics in componenttest #11172
Conversation
25aa963
to
0732197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love this idea, will need to do a full review but i think it makes sense to remove. are there still e2e tests that validate the output from the service?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11172 +/- ##
==========================================
- Coverage 92.28% 91.86% -0.43%
==========================================
Files 413 413
Lines 19761 19766 +5
==========================================
- Hits 18237 18158 -79
- Misses 1152 1239 +87
+ Partials 372 369 -3 ☔ View full report in Codecov by Sentry. |
Yes in https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/service_test.go |
@codeboten ping :) |
|
Signed-off-by: Bogdan Drutu <[email protected]>
0732197
to
f26d92d
Compare
No description provided.