Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove prometheus need to check test metrics in componenttest #11172

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and djaglowski September 13, 2024 20:28
@bogdandrutu bogdandrutu changed the title Remove prometheus need to check test metrics in componenttest [chore] Remove prometheus need to check test metrics in componenttest Sep 13, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this idea, will need to do a full review but i think it makes sense to remove. are there still e2e tests that validate the output from the service?

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.

Project coverage is 91.86%. Comparing base (d3a1718) to head (f26d92d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
component/componenttest/otelchecker.go 0.00% 106 Missing ⚠️
component/componenttest/obsreporttest.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11172      +/-   ##
==========================================
- Coverage   92.28%   91.86%   -0.43%     
==========================================
  Files         413      413              
  Lines       19761    19766       +5     
==========================================
- Hits        18237    18158      -79     
- Misses       1152     1239      +87     
+ Partials      372      369       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Sep 13, 2024

i love this idea, will need to do a full review but i think it makes sense to remove. are there still e2e tests that validate the output from the service?

Yes in https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/service_test.go

@bogdandrutu
Copy link
Member Author

@codeboten ping :)

@codeboten
Copy link
Contributor

/home/runner/work/opentelemetry-collector/opentelemetry-collector/.tools/golangci-lint run
Error: componenttest/otelchecker.go:131:49: `unknwon` is a misspelling of `unknown` (misspell)
		return metricdata.DataPoint[N]{}, fmt.Errorf("unknwon metric type: %T", a)

@bogdandrutu bogdandrutu merged commit 1339c01 into open-telemetry:main Sep 16, 2024
47 of 49 checks passed
@bogdandrutu bogdandrutu deleted the useotelmanual branch September 16, 2024 23:56
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants