Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable go-require rule from testifylint #11174

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint is a linter that provides best practices with the use of testify.

This PR enables go-require rule from testifylint

@mmorel-35 mmorel-35 requested review from a team and jpkrohling September 14, 2024 15:22
@mmorel-35 mmorel-35 marked this pull request as draft September 14, 2024 15:22
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (66db5ba) to head (c3bcacb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11174   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         415      415           
  Lines       19850    19850           
=======================================
  Hits        18232    18232           
  Misses       1245     1245           
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the testifylint/go-require branch 2 times, most recently from 61c2454 to d9264cc Compare September 14, 2024 15:38
@mmorel-35 mmorel-35 marked this pull request as ready for review September 14, 2024 15:43
@mmorel-35 mmorel-35 force-pushed the testifylint/go-require branch from d9264cc to 59cdcbc Compare September 17, 2024 05:14
.golangci.yml Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 force-pushed the testifylint/go-require branch 2 times, most recently from 5a215f8 to 92038ff Compare September 17, 2024 17:46
@mmorel-35 mmorel-35 force-pushed the testifylint/go-require branch from 92038ff to c3bcacb Compare September 17, 2024 17:48
@codeboten codeboten merged commit 51f321a into open-telemetry:main Sep 17, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 17, 2024
@mmorel-35 mmorel-35 deleted the testifylint/go-require branch September 17, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants