Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move mdatagen code to internal, no public API needed #11181

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and evan-bradley September 16, 2024 19:04
@bogdandrutu bogdandrutu force-pushed the mv-mdatagen-internal branch 3 times, most recently from 3745473 to 2e05a71 Compare September 16, 2024 20:19
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (d3a1718) to head (6c4ea51).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/loader.go 66.66% 6 Missing ⚠️
cmd/mdatagen/main.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11181   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         413      413           
  Lines       19761    19761           
=======================================
  Hits        18237    18237           
  Misses       1152     1152           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 2c0941f into open-telemetry:main Sep 16, 2024
47 of 49 checks passed
@bogdandrutu bogdandrutu deleted the mv-mdatagen-internal branch September 16, 2024 20:58
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants