-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove use of alias types in service/telemetry #11182
Conversation
f0425b1
to
fbb7f11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11182 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 422 422
Lines 20002 20002
=======================================
Hits 18365 18365
Misses 1262 1262
Partials 375 375 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
fbb7f11
to
2643e82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the internal aliasing stuff may have been needed as part of the refactor but not now. In any case I believe this leaves the API surface the same so if we were to need this we can always revisit this
Thanks for confirming! |
This PR moves internal definitions that were aliased publicly to the public package, and makes sure that hides any other type so that the API surface is the same.