Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove use of alias types in service/telemetry #11182

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

bogdandrutu
Copy link
Member

This PR moves internal definitions that were aliased publicly to the public package, and makes sure that hides any other type so that the API surface is the same.

@bogdandrutu bogdandrutu requested review from a team and jpkrohling September 16, 2024 21:01
@bogdandrutu bogdandrutu force-pushed the rm-alias branch 3 times, most recently from f0425b1 to fbb7f11 Compare September 17, 2024 21:21
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 49.18033% with 31 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (1edd311) to head (61ddbe6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
service/telemetry/factory.go 15.38% 22 Missing ⚠️
service/telemetry/factory_impl.go 74.28% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11182   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         422      422           
  Lines       20002    20002           
=======================================
  Hits        18365    18365           
  Misses       1262     1262           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten
Copy link
Contributor

codeboten commented Sep 19, 2024

I was looking at the original PR, @mx-psi was there a reason to have the internal aliases?

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the internal aliasing stuff may have been needed as part of the refactor but not now. In any case I believe this leaves the API surface the same so if we were to need this we can always revisit this

@codeboten
Copy link
Contributor

Thanks for confirming!

@codeboten codeboten merged commit 7253ab8 into open-telemetry:main Sep 20, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 20, 2024
@bogdandrutu bogdandrutu deleted the rm-alias branch September 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants