[chore] Move metrics initialization in service/telemetry #11185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
movemetricsinit
branch
3 times, most recently
from
1aa31ca to
8f65a8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11185 +/- ##
==========================================
+ Coverage 91.86% 91.88% +0.02%
==========================================
Files 413 416 +3
Lines 19766 19864 +98
==========================================
+ Hits 18158 18252 +94
+ Misses 1239 1236 -3
- Partials 369 376 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
movemetricsinit
branch
from
8f65a8f to
ae7b9cb
Compare
codeboten
approved these changes
Sep 17, 2024
| "go.opentelemetry.io/collector/service/telemetry/internal" | ||
| ) | ||
|
|
||
| // disableHighCardinalityMetricsfeatureGate is the feature gate that controls whether the collector should enable | ||
| // potentially high cardinality metrics. The gate will be removed when the collector allows for view configuration. | ||
| var disableHighCardinalityMetricsfeatureGate = featuregate.GlobalRegistry().MustRegister( |
There was a problem hiding this comment.
Should this be moved to globalgates instead?
There was a problem hiding this comment.
Why? Where else is used? My understanding is that in globalgates we put things shared between components/modules.
There was a problem hiding this comment.
ah, i just thought of it as a convenient location for all feature gates 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.