Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add exporterhelperprofiles package #11226

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 20, 2024

Description

This is extracted from #11131.
It adds profiles support for the epxorterhelper, so both the otlp and otlphttp exporters can support that signal.

It requires #11207✅ and #11225✅ to be merged first.

@dmathieu dmathieu force-pushed the exporterhelperprofiles branch 3 times, most recently from 2c2f0ce to daed833 Compare September 20, 2024 08:43
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 91.08280% with 14 lines in your changes missing coverage. Please review.

Project coverage is 92.14%. Comparing base (4f2a8d3) to head (9ad550f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../exporterhelper/exporterhelperprofiles/profiles.go 91.80% 3 Missing and 2 partials ⚠️
exporter/exporterhelper/internal/obsexporter.go 0.00% 5 Missing ⚠️
...terhelper/exporterhelperprofiles/profiles_batch.go 97.75% 1 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/request.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11226      +/-   ##
==========================================
- Coverage   92.15%   92.14%   -0.01%     
==========================================
  Files         431      433       +2     
  Lines       20232    20389     +157     
==========================================
+ Hits        18644    18787     +143     
- Misses       1227     1238      +11     
- Partials      361      364       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the exporterhelperprofiles branch from daed833 to b740c57 Compare September 20, 2024 09:50
Copy link
Contributor

github-actions bot commented Oct 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 5, 2024
@dmathieu dmathieu force-pushed the exporterhelperprofiles branch 2 times, most recently from d036d6a to 3e46c28 Compare October 9, 2024 14:34
@dmathieu dmathieu marked this pull request as ready for review October 9, 2024 14:37
@dmathieu dmathieu requested a review from a team as a code owner October 9, 2024 14:37
@dmathieu dmathieu requested a review from codeboten October 9, 2024 14:37
@mx-psi mx-psi self-requested a review October 9, 2024 14:39
@dmathieu dmathieu force-pushed the exporterhelperprofiles branch 2 times, most recently from 81f7da9 to 53c9c54 Compare October 9, 2024 15:23
use pipelineprofiles instead of componentprofiles
@mx-psi mx-psi merged commit 388bae7 into open-telemetry:main Oct 16, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 16, 2024
@dmathieu dmathieu deleted the exporterhelperprofiles branch October 16, 2024 11:27
mx-psi pushed a commit that referenced this pull request Oct 18, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires #11226✅  to be merged first.
mx-psi pushed a commit that referenced this pull request Oct 18, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP exporter.

This PR requires #11226✅  to be merged first.
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from open-telemetry#11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires open-telemetry#11207✅  and open-telemetry#11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires open-telemetry#11226✅  to be merged first.
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP exporter.

This PR requires open-telemetry#11226✅  to be merged first.
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from open-telemetry#11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires open-telemetry#11207✅  and open-telemetry#11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires open-telemetry#11226✅  to be merged first.
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP exporter.

This PR requires open-telemetry#11226✅  to be merged first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants