Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logs scraper in factory #11822

Closed
wants to merge 1 commit into from
Closed

Add logs scraper in factory #11822

wants to merge 1 commit into from

Conversation

sincejune
Copy link
Contributor

Description

Add scraper for logs(#11799) in the factory

Link to tracking issue

Relates to #11238 , #11799

Testing

Added

Documentation

Updated the previous change log file

@sincejune sincejune requested a review from a team as a code owner December 8, 2024 16:16
@sincejune sincejune mentioned this pull request Dec 8, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (e970f8b) to head (ab028c9).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11822   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         461      461           
  Lines       24685    24697   +12     
=======================================
+ Hits        22625    22637   +12     
  Misses       1678     1678           
  Partials      382      382

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 requested a review from bogdandrutu December 9, 2024 16:18
@sincejune
Copy link
Contributor Author

@bogdandrutu @evan-bradley Could we please add Skip Changelog label to this PR? This is a follow-up PR of #11799 and I've updated the existing change log in the PR. Thanks!

atoulme
atoulme reviewed Dec 11, 2024
View reviewed changes
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 11, 2024
atoulme
atoulme approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit on a comment.

@songy23 songy23 added the ready-to-merge Code review completed; ready to merge by maintainers label Dec 12, 2024
@sincejune
Copy link
Contributor Author

ping

@sincejune sincejune force-pushed the add-logs-scraper-in-factory branch from 38d6999 to ab028c9 Compare January 17, 2025 06:41
@sincejune
Copy link
Contributor Author

Closing this in favor of #12116

cc @bogdandrutu

@sincejune sincejune closed this Jan 17, 2025
@sincejune sincejune deleted the add-logs-scraper-in-factory branch January 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sincejune @atoulme @bogdandrutu @songy23