Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecaterd consumererrorprofiles module #11916

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dmitryax
Copy link
Member

go.opentelemetry.io/collector/consumer/consumererror/xconsumererror should be used instead.

@dmitryax dmitryax requested a review from a team as a code owner December 17, 2024 00:18
@dmitryax dmitryax changed the title Remove consumererrorprofiles module Remove deprecaterd consumererrorprofiles module Dec 17, 2024
@dmitryax dmitryax enabled auto-merge December 17, 2024 00:25
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (a8832a8) to head (b5e7c4d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11916   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         447      447           
  Lines       23729    23729           
=======================================
  Hits        21741    21741           
  Misses       1613     1613           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 17, 2024
@mx-psi
Copy link
Member

mx-psi commented Dec 17, 2024

@dmitryax needs a rebase

@dmitryax dmitryax force-pushed the remove-consumererrorprofiles branch from 8aa748f to 8f3bbef Compare December 17, 2024 17:04
@dmitryax dmitryax enabled auto-merge December 17, 2024 17:04
@bogdandrutu
Copy link
Member

Needs a rebase.

go.opentelemetry.io/collector/consumer/consumererror/xconsumererror should be used instead.
@dmitryax dmitryax force-pushed the remove-consumererrorprofiles branch from 8f3bbef to b5e7c4d Compare December 17, 2024 17:24
@dmitryax dmitryax added this pull request to the merge queue Dec 17, 2024
Merged via the queue into open-telemetry:main with commit bb27be0 Dec 17, 2024
50 of 51 checks passed
@dmitryax dmitryax deleted the remove-consumererrorprofiles branch December 17, 2024 18:03
@github-actions github-actions bot added this to the next release milestone Dec 17, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
should be used instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants