Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable use-any rule from revive linter #11926

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 17, 2024

Description

Activates and apply use-any rule from revive to use any instead of interface{}

Also moves revive config later in the list to try to keep alphabetical order.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (4d8c04f) to head (95dd848).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/telemetry.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11926   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi added this pull request to the merge queue Dec 17, 2024
Merged via the queue into open-telemetry:main with commit 2dda2ac Dec 17, 2024
49 of 50 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 17, 2024
@mmorel-35 mmorel-35 deleted the revive/use-any branch December 17, 2024 10:18
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
#### Description
Activates and apply use-any rule from revive to use any instead of
interface{}

Also moves revive config later in the list to try to keep alphabetical
order.

Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants