[chore][exporterhelper] Fix feature gate setting for unit tests. #11927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
sfc-gh-sili
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11927 +/- ##
==========================================
+ Coverage 91.59% 91.62% +0.03%
==========================================
Files 449 447 -2
Lines 23761 23729 -32
==========================================
- Hits 21763 21741 -22
+ Misses 1623 1613 -10
Partials 375 375 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-fix-test
branch
from
82226c0 to
27d5d42
Compare
dmitryax
approved these changes
Dec 18, 2024
Merged
via the queue into
open-telemetry:main
with commit Dec 18, 2024
936ef35
50 of 51 checks passed
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…n-telemetry#11927) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Before fix: `defer setFeatureGateForTest(t, usePullingBasedExporterQueueBatcher, enableQueueBatcher)` This means run `setFeatureGateForTest` in the end. After fix: `defer setFeatureGateForTest(t, usePullingBasedExporterQueueBatcher, enableQueueBatcher)()` This means: run `setFeatureGateForTest` immediately but execute the function returned from `setFeatureGateForTest` in the end. <!-- Issue number if applicable --> #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before fix:
defer setFeatureGateForTest(t, usePullingBasedExporterQueueBatcher, enableQueueBatcher)This means run
setFeatureGateForTestin the end.After fix:
defer setFeatureGateForTest(t, usePullingBasedExporterQueueBatcher, enableQueueBatcher)()This means: run
setFeatureGateForTestimmediately but execute the function returned fromsetFeatureGateForTestin the end.Link to tracking issue
Fixes #
Testing
Documentation