Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pdata to v1.5.0 #11932

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

dmathieu
Copy link
Member

Description

Proto 1.5.0 has been released. This upgrades pdata to use that version.
See https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.5.0

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (4fc50a8) to head (f822c58).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11932      +/-   ##
==========================================
+ Coverage   91.59%   91.62%   +0.03%     
==========================================
  Files         448      447       -1     
  Lines       23759    23737      -22     
==========================================
- Hits        21761    21749      -12     
+ Misses       1623     1613      -10     
  Partials      375      375              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// Attributes returns the Attributes associated with this Profile.
//
// Deprecated: [v0.117.0] This field has been removed, and replaced with AttributeIndices
func (ms Profile) Attributes() pcommon.Map {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method prevents panics on contrib. It's not a great solution either though, as it makes attributes readable, but not writable (and we can't make them writable, since we can't look for changes in pcommon.Map).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes more sense to just remove this. It's a bigger breakage, but it's more noticeable that writes silently failing

@dmathieu
Copy link
Member Author

Unfortunately, due to a change in the way profile attributes are handled, this brings a breaking change to contrib, which isn't really fixable (we can read the data from the old method, but not write).
The contrib fix is here: open-telemetry/opentelemetry-collector-contrib#36868

I'd suggest a coordinated merge of the two PRs.

@dmathieu dmathieu marked this pull request as ready for review December 17, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants