Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Use gotestsum wrapper for go tests #11946

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

ankitpatel96
Copy link
Contributor

Description:

Use gotestyourself/gotestsum for running tests.
This is following contrib's lead - they implemented this in this PR.

Gotestsum is a lot more readable and user friendly than go test - the output format is nicer and the test output is more parseable. We could also use rerun on failed or some of their other features!

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (4cf491b) to head (6b7d3c6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11946   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         447      447           
  Lines       23729    23729           
=======================================
  Hits        21741    21741           
  Misses       1613     1613           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankitpatel96 ankitpatel96 marked this pull request as ready for review December 17, 2024 23:19
@ankitpatel96 ankitpatel96 requested a review from a team as a code owner December 17, 2024 23:19
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since we already use this in contrib

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Dec 18, 2024
@codeboten codeboten added this pull request to the merge queue Dec 18, 2024
Merged via the queue into open-telemetry:main with commit 1b4e1ee Dec 18, 2024
43 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 18, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
**Description:**

Use
[gotestyourself/gotestsum](https://github.com/gotestyourself/gotestsum?rgh-link-date=2024-02-09T12%3A20%3A03Z)
for running tests.
This is following contrib's lead - they implemented this in this
[PR](open-telemetry/opentelemetry-collector-contrib#31163).

Gotestsum is a lot more readable and user friendly than go test - the
output format is nicer and the test output is more parseable. We could
also use [rerun on
failed](https://github.com/gotestyourself/gotestsum#re-running-failed-tests)
or some of their other features!

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants