[chore][extension] update NotifyConfig contract #9005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evan Bradley <[email protected]>
evan-bradley
approved these changes
Nov 28, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9005 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 316 316
Lines 17121 17121
=======================================
Hits 15676 15676
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
tigrannajaryan
approved these changes
Nov 28, 2023
dmitryax
approved these changes
Nov 28, 2023
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
**Description:** The collector implementation makes a copy of effective configuration before calling `NotifyConfig` so it's safe for the config watcher to save the pointer and use it later. It is resonable to promise this in the API contract. **Link to tracking Issue:** open-telemetry/opentelemetry-collector-contrib#29277 (comment) --------- Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The collector implementation makes a copy of effective configuration before calling
NotifyConfigso it's safe for the config watcher to save the pointer and use it later. It is resonable to promise this in the API contract.Link to tracking Issue: open-telemetry/opentelemetry-collector-contrib#29277 (comment)
Testing: No behavior changes.
Documentation: godoc