🐛 Fix OpentelemetryFinch handler on Finch.stream_while #398
+121
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparcus
changed the title
|
Hello 👋 |
rparcus
commented
Nov 20, 2024
| @@ -44,8 +44,17 @@ defmodule OpentelemetryFinch do | |||
|
|
|||
| status = | |||
| case meta.result do | |||
| {:ok, response} -> response.status | |||
| _ -> 0 | |||
| {:ok, response} when is_map(response) -> | |||
There was a problem hiding this comment.
The main issue was here. Not every response contains a status key as it depends on the implementation of the streaming callback functions.
A fallback case is also added. In this fix, I'm not trying to come up with a general solution but just one that works for the patterns I saw. The tests use callbacks that return values in the patterns I was already working with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327