add happy path test

Signed-off-by: Moritz Wiesinger <[email protected]>

githubgen/codeowners.go

@@ -111,20 +111,20 @@ func (cg *codeownersGenerator) verifyCodeOwnerOrgMembership(allowlistData []byte
 	var missingCodeowners []string
 	var duplicateCodeowners []string
 
-	members, err := cg.getGithubMembers()
+	members, err := cg.GetGithubMembers()
 	if err != nil {
 		return err
 	}
 
 	// sort codeowners
 	for _, codeowner := range data.Codeowners {
-		_, present := members[codeowner]
+		_, ownerPresentInMembers := members[codeowner]
 
-		if !present {
-			_, allowed := allowlist[codeowner]
+		if !ownerPresentInMembers {
+			_, ownerInAllowlist := allowlist[codeowner]
 			delete(unusedAllowlist, codeowner)
-			allowed = allowed || strings.HasPrefix(codeowner, "open-telemetry/")
-			if !allowed {
+			ownerInAllowlist = ownerInAllowlist || strings.HasPrefix(codeowner, "open-telemetry/")
+			if !ownerInAllowlist {
 				missingCodeowners = append(missingCodeowners, codeowner)
 			}
 		} else if _, exists := allowlist[codeowner]; exists {
@@ -152,7 +152,7 @@ func (cg *codeownersGenerator) verifyCodeOwnerOrgMembership(allowlistData []byte
 	return err
 }
 
-func (cg *codeownersGenerator) getGithubMembers() (map[string]struct{}, error) {
+func (cg *codeownersGenerator) GetGithubMembers() (map[string]struct{}, error) {
 	if cg.skipGithub {
 		// don't try to get organization members if no token is expected
 		return map[string]struct{}{}, nil

githubgen/codeowners_test.go

@@ -7,25 +7,34 @@ import (
 )
 
 func Test_codeownersGenerator_verifyCodeOwnerOrgMembership(t *testing.T) {
-	type fields struct {
-		skipGithub bool
-	}
 	type args struct {
 		allowlistData []byte
 		data          datatype.GithubData
 	}
 	tests := []struct {
-		name    string
-		fields  fields
-		args    args
-		wantErr bool
+		name       string
+		skipGithub bool
+		args       args
+		wantErr    bool
 	}{
-		// TODO: Add test cases.
+		{
+			name:       "happy path",
+			skipGithub: true,
+			args: args{
+				allowlistData: []byte(""),
+				data: datatype.GithubData{
+					Codeowners: []string{
+						"user1", "user2", "user3",
+					},
+				},
+			},
+			wantErr: false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			cg := &codeownersGenerator{
-				skipGithub: tt.fields.skipGithub,
+				skipGithub: tt.skipGithub,
 			}
 			if err := cg.verifyCodeOwnerOrgMembership(tt.args.allowlistData, tt.args.data); (err != nil) != tt.wantErr {
 				t.Errorf("verifyCodeOwnerOrgMembership() error = %v, wantErr %v", err, tt.wantErr)