Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin markdown-link-check to 3.12.2 #613

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Nov 6, 2024

As the more recent versions are broken, and falsely fail the build.

See tcort/markdown-link-check#369
Related: open-telemetry/opentelemetry-collector-contrib#36223

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 6, 2024
@dmathieu dmathieu requested review from a team as code owners November 6, 2024 10:30
@dmathieu dmathieu requested a review from codeboten November 6, 2024 10:30
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.16%. Comparing base (429b99c) to head (da66b87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   53.10%   51.16%   -1.94%     
==========================================
  Files          51       51              
  Lines        2258     2881     +623     
==========================================
+ Hits         1199     1474     +275     
- Misses        912     1260     +348     
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu merged commit 8865664 into open-telemetry:main Nov 6, 2024
12 of 13 checks passed
@dmathieu dmathieu deleted the pin-markdown-link-check branch November 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants