Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] add govulncheck #4417

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[chore] add govulncheck #4417

merged 3 commits into from
Oct 19, 2023

Conversation

sakshi-1505
Copy link
Contributor

fixes #4413

@sakshi-1505 sakshi-1505 requested a review from a team October 12, 2023 05:15
@sakshi-1505
Copy link
Contributor Author

@codeboten @pellared Please take a look

pellared
pellared reviewed Oct 12, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
pellared
pellared reviewed Oct 12, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 12, 2023
@pellared pellared changed the title feat: add govulncheck for staticcheck & audit purpose [chore] add govulncheck Oct 12, 2023
pellared
pellared approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixes some little issues. Looks good. We just need to do something like here open-telemetry/opentelemetry-go#4607 to fix the reported issues.

Thanks for your contribution 👍

@pellared pellared mentioned this pull request Oct 12, 2023
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Oct 18, 2023

Please fix the issues this uncovers so the CI system will pass and this can be merged.

@MrAlias MrAlias added the response needed Waiting on user input before progress can be made label Oct 18, 2023
@pellared pellared removed the response needed Waiting on user input before progress can be made label Oct 19, 2023
@pellared
Copy link
Member

@sakshi-1505 Thanks 🎉

@pellared pellared merged commit 488b204 into open-telemetry:main Oct 19, 2023
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

[security] audit repository tooling
4 participants
@sakshi-1505 @MrAlias @pellared @hanyuancheung