Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(otelgin): refactor HTTP server attributes to use new semconv package #6778

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Feb 13, 2025

closed #6764

@flc1125
Copy link
Member Author

flc1125 commented Feb 13, 2025

This PR has some duplicated (conflicting) content with #6747, and I'm resolving the conflicts after one of them is merged.

@github-actions github-actions bot requested a review from akats7 February 13, 2025 15:02
@flc1125 flc1125 marked this pull request as ready for review February 13, 2025 15:02
@flc1125 flc1125 requested a review from a team as a code owner February 13, 2025 15:02
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 88.44221% with 92 lines in your changes missing coverage. Please review.

Project coverage is 75.5%. Comparing base (2c0f3ba) to head (efdde97).

Files with missing lines Patch % Lines
...gin-gonic/gin/otelgin/internal/semconv/httpconv.go 86.0% 42 Missing and 15 partials ⚠️
.../gin-gonic/gin/otelgin/internal/semconv/v1.20.0.go 89.9% 11 Missing and 7 partials ⚠️
....com/gin-gonic/gin/otelgin/internal/semconv/env.go 92.5% 9 Missing and 2 partials ⚠️
...com/gin-gonic/gin/otelgin/internal/semconv/util.go 89.4% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6778     +/-   ##
=======================================
+ Coverage   74.9%   75.5%   +0.5%     
=======================================
  Files        203     207      +4     
  Lines      18323   19116    +793     
=======================================
+ Hits       13738   14439    +701     
- Misses      4175    4241     +66     
- Partials     410     436     +26     
Files with missing lines Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 90.1% <100.0%> (+0.2%) ⬆️
...com/gin-gonic/gin/otelgin/internal/semconv/util.go 89.4% <89.4%> (ø)
....com/gin-gonic/gin/otelgin/internal/semconv/env.go 92.5% <92.5%> (ø)
.../gin-gonic/gin/otelgin/internal/semconv/v1.20.0.go 89.9% <89.9%> (ø)
...gin-gonic/gin/otelgin/internal/semconv/httpconv.go 86.0% <86.0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(otelgin): replace direct semconv usage with internal semconv package
1 participant