Address comments

open-telemetry · Nov 15, 2023 · af08f24 · af08f24
1 parent 2f36c24
commit af08f24
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go b/exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go
@@ -267,8 +267,8 @@ func NewHTTPCollector(endpoint string, resultCh <-chan ExportResult, opts ...fun
 	return c, nil
 }
 
-// WithHTTPCollectorRespondingPlainText makes the HTTPCollector to return a
-// plaintext, instead of protobuf, response.
+// WithHTTPCollectorRespondingPlainText makes the HTTPCollector return
+// a plaintext, instead of protobuf, response.
 func WithHTTPCollectorRespondingPlainText() func(*HTTPCollector) {
 	return func(s *HTTPCollector) {
 		s.plainTextResponse = true
@@ -398,7 +398,7 @@ func (c *HTTPCollector) respond(w http.ResponseWriter, resp ExportResult) {
 	if c.plainTextResponse {
 		w.Header().Set("Content-Type", "text/plain; charset=utf-8")
 		w.WriteHeader(http.StatusOK)
-		_, _ = io.WriteString(w, "OK")
+		_, _ = w.Write([]byte("OK"))
 		return
 	}
 

diff --git a/exporters/otlp/otlpmetric/otlpmetrichttp/internal/otest/collector.go b/exporters/otlp/otlpmetric/otlpmetrichttp/internal/otest/collector.go
@@ -267,8 +267,8 @@ func NewHTTPCollector(endpoint string, resultCh <-chan ExportResult, opts ...fun
 	return c, nil
 }
 
-// WithHTTPCollectorRespondingPlainText makes the HTTPCollector to return a
-// plaintext, instead of protobuf, response.
+// WithHTTPCollectorRespondingPlainText makes the HTTPCollector return
+// a plaintext, instead of protobuf, response.
 func WithHTTPCollectorRespondingPlainText() func(*HTTPCollector) {
 	return func(s *HTTPCollector) {
 		s.plainTextResponse = true
@@ -398,7 +398,7 @@ func (c *HTTPCollector) respond(w http.ResponseWriter, resp ExportResult) {
 	if c.plainTextResponse {
 		w.Header().Set("Content-Type", "text/plain; charset=utf-8")
 		w.WriteHeader(http.StatusOK)
-		_, _ = io.WriteString(w, "OK")
+		_, _ = w.Write([]byte("OK"))
 		return
 	}
 

diff --git a/internal/shared/otlp/otlpmetric/otest/collector.go.tmpl b/internal/shared/otlp/otlpmetric/otest/collector.go.tmpl
@@ -267,8 +267,8 @@ func NewHTTPCollector(endpoint string, resultCh <-chan ExportResult, opts ...fun
 	return c, nil
 }
 
-// WithHTTPCollectorRespondingPlainText makes the HTTPCollector to return a
-// plaintext, instead of protobuf, response.
+// WithHTTPCollectorRespondingPlainText makes the HTTPCollector return
+// a plaintext, instead of protobuf, response.
 func WithHTTPCollectorRespondingPlainText() func(*HTTPCollector) {
 	return func(s *HTTPCollector) {
 		s.plainTextResponse = true
@@ -398,7 +398,7 @@ func (c *HTTPCollector) respond(w http.ResponseWriter, resp ExportResult) {
 	if c.plainTextResponse {
 		w.Header().Set("Content-Type", "text/plain; charset=utf-8")
 		w.WriteHeader(http.StatusOK)
-		_, _ = io.WriteString(w, "OK")
+		_, _ = w.Write([]byte("OK"))
 		return
 	}