Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlpmetrichttp otlptracehttp: Do not parse non-protobuf reponses #4719

Merged
merged 4 commits into from
Nov 16, 2023

Add a case for respData.Len() == 0

46d0335
Select commit
Loading
Failed to load commit list.
Merged

otlpmetrichttp otlptracehttp: Do not parse non-protobuf reponses #4719

Add a case for respData.Len() == 0
46d0335
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 15, 2023 in 0s

61.1% of diff hit (target 81.8%)

View this Pull Request on Codecov

61.1% of diff hit (target 81.8%)

Annotations

Check warning on line 222 in exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go#L222

Added line #L222 was not covered by tests

Check warning on line 241 in exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go#L239-L241

Added lines #L239 - L241 were not covered by tests

Check warning on line 275 in exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go#L272-L275

Added lines #L272 - L275 were not covered by tests

Check warning on line 403 in exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go#L398-L403

Added lines #L398 - L403 were not covered by tests