Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-reader observable counter double-counting bug #4742

Merged
merged 3 commits into from
Dec 8, 2023

restore comment

c3d7689
Select commit
Loading
Failed to load commit list.
Merged

Fix multi-reader observable counter double-counting bug #4742

restore comment
c3d7689
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 8, 2023 in 0s

82.0% (+0.0%) compared to 214d5e0

View this Pull Request on Codecov

82.0% (+0.0%) compared to 214d5e0

Details

Codecov Report

Merging #4742 (c3d7689) into main (214d5e0) will increase coverage by 0.0%.
The diff coverage is 93.2%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4742   +/-   ##
=====================================
  Coverage   82.0%   82.0%           
=====================================
  Files        225     225           
  Lines      18239   18242    +3     
=====================================
+ Hits       14961   14976   +15     
+ Misses      2989    2981    -8     
+ Partials     289     285    -4     
Files Coverage Δ
sdk/metric/instrument.go 93.5% <100.0%> (+0.2%) ⬆️
sdk/metric/pipeline.go 86.2% <100.0%> (-0.2%) ⬇️
sdk/metric/meter.go 92.5% <91.8%> (+3.5%) ⬆️