feat(esbuild-plugin): esbuild plugin to prepare bundled modules for instrumentation #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation (More details to come.) Refs: open-telemetry#1856 Refs: open-telemetry/opentelemetry-js#4818
|
👋 As I mentioned in the other PR, here's my adapted plugin. I made a couple tweaks around caching results, in particular trying to use There might be more optimizations that can be done here, but this has gotten us to the "good enough" point. Hope you find it useful! https://gist.github.com/rossipedia/341501ed93ea5b1089da143ac49e6697 |
… need for wait for batch span send at the end of app.js
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+10
to
+13
| server.get('/ping', async (req, reply) => { | ||
| const bar = await redis.get('bar'); | ||
| reply.send(`pong (redis key "bar" is: ${bar})`); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(More details to come.)
Refs: #1856
Refs: open-telemetry/opentelemetry-js#4818