fix(exporter-metrics-otlp-http): browser OTLPMetricExporter was not passing config to OTLPMetricExporterBase super class #5331
+151
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assing config to OTLPMetricExporterBase super class Refs: open-telemetry#5031
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5331 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 322 322
Lines 8132 8132
Branches 1715 1715
=======================================
Hits 7690 7690
Misses 442 442 |
raphael-theriault-swi
approved these changes
Jan 10, 2025
pichlermarc
added
bug
pichlermarc
approved these changes
Jan 13, 2025
Yep, I'll backport this ASAP. |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Jan 13, 2025
…assing config to OTLPMetricExporterBase super class (open-telemetry#5331)
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Jan 13, 2025
…s not passing config to OTLPMetricExporterBase super class (open-telemetry#5331)
pichlermarc
added a commit
that referenced
this pull request
Jan 13, 2025
…porter was not passing config to OTLPMetricExporterBase super class [#5331] (#5337) Co-authored-by: Trent Mick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #5031
This was pointed out in Slack here: https://cloud-native.slack.com/archives/C01NL1GRPQR/p1736535825217819
My PR copies some of the test blocks from "test/node/OTLPMetricExporter.test.ts" (those that were passing
config to
OTLPMetricExporter) over to the platform test file./cc @pichlermarc