Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk-base)!: Use TypeScript overload signature for addEvent #5359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

refactor(api)!: Use TypeScript overload signature for `addEvent`

4f7c300
Select commit
Loading
Failed to load commit list.
Open

refactor(sdk-base)!: Use TypeScript overload signature for addEvent #5359

refactor(api)!: Use TypeScript overload signature for `addEvent`
4f7c300
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 0s

94.54% (+0.00%) compared to c00f36e

View this Pull Request on Codecov

94.54% (+0.00%) compared to c00f36e

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (c00f36e) to head (4f7c300).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5359   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         318      318           
  Lines        8051     8051           
  Branches     1694     1694           
=======================================
  Hits         7612     7612           
  Misses        439      439
Files with missing lines Coverage Δ
api/src/trace/NonRecordingSpan.ts 95.65% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 97.61% <100.00%> (ø)
View more details on Codecov