-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): introduce replacement functions for getEnv, getEnvWithoutDefaults #5429
Draft
pichlermarc
wants to merge
9
commits into
open-telemetry:main
Choose a base branch
from
dynatrace-oss-contrib:feat/get-env-replacement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(core): introduce replacement functions for getEnv, getEnvWithoutDefaults #5429
pichlermarc
wants to merge
9
commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/get-env-replacement
+872
−543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5429 +/- ##
==========================================
- Coverage 94.79% 90.42% -4.37%
==========================================
Files 310 310
Lines 7974 8022 +48
Branches 1682 1715 +33
==========================================
- Hits 7559 7254 -305
- Misses 415 768 +353
|
82b06b8
to
b6c1ca9
Compare
01d0deb
to
9a91af9
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Note
Draft PR to show the whole change. I'll break those up into more digestible pieces.
See #5217
This attempts to solve this by introducing new functions that map to the spec's idea of which types of env vars exist. It leaves some out, but the one's I've left out are mostly convenience functions that we can add added later. Base functionality can be established with just getting
string
,number
,boolean
andstring[]
from environment variables.Most environment variables are only used once. At the moment, everyone that uses
getEnv()
has to import and parse all environment variables, even the ones they don't care about. The properties fromENVIRONMENT
can also not be minified, nor tree-shaken - similar to what was happening with@opentelemetry/semantic-conventions
but at a smaller scale.With the proposed change here
OTEL_SEMCONV_STABILITY_OPT_IN
could be exported from@opentelemetry/instrumentation
, for instance)@opentelemetry/core
packages anymoregetEnv()
andgetEnvWithoutDefaults()
,ENVIRONMENT
,DEFAULT_ENVIRONMENT
,RAW_ENVIRONMENT
, et al. in a follow-upType of change
How Has This Been Tested?
Checklist: