Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int test fix - alternate approach #2521

Closed
wants to merge 4 commits into from

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 16, 2025

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb changed the title Int test fix - alternate approach to demonstrate Int test fix - alternate approach Jan 16, 2025
@lalitb lalitb added the integration tests Run integration tests label Jan 16, 2025
@lalitb lalitb mentioned this pull request Jan 16, 2025
4 tasks
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (c51c4b2) to head (e564e7a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2521   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22944   22944           
=====================================
  Hits       17880   17880           
  Misses      5064    5064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Jan 17, 2025

fixed in #2525

@lalitb lalitb closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant