Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Zipkin pipeline with exporter builders #2565

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jan 25, 2025

Fixes #2473

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner January 25, 2025 17:47
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.6%. Comparing base (144fdd9) to head (7afb76b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-zipkin/src/exporter/mod.rs 0.0% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2565     +/-   ##
=======================================
+ Coverage   79.4%   79.6%   +0.2%     
=======================================
  Files        118     118             
  Lines      22526   22464     -62     
=======================================
- Hits       17898   17897      -1     
+ Misses      4628    4567     -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruebel gruebel requested a review from cijothomas January 26, 2025 13:33
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Need to address fixing the example (to show the global set provider) and async_trait before merge.

Thanks for helping!

@gruebel gruebel requested a review from cijothomas January 28, 2025 19:34
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cijothomas cijothomas merged commit 17cce83 into open-telemetry:main Jan 29, 2025
20 of 21 checks passed
@gruebel gruebel deleted the refactor-zipkin-pipeline branch February 2, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Zipkin export pipeline methods
3 participants