-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace Zipkin pipeline with exporter builders #2565
feat: Replace Zipkin pipeline with exporter builders #2565
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
=======================================
+ Coverage 79.4% 79.6% +0.2%
=======================================
Files 118 118
Lines 22526 22464 -62
=======================================
- Hits 17898 17897 -1
+ Misses 4628 4567 -61 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Need to address fixing the example (to show the global set provider) and async_trait before merge.
Thanks for helping!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #2473
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes