Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary public methods from OTLP Exporter #2575

Merged

Conversation

cijothomas
Copy link
Member

In a future PR, based on the outcome of #2571 the exporter_builder::build() method would be returning a different Result than what it does today.

@cijothomas cijothomas requested a review from a team as a code owner January 30, 2025 00:43
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.6%. Comparing base (8520610) to head (902294e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/metric.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2575   +/-   ##
=====================================
  Coverage   79.6%   79.6%           
=====================================
  Files        118     118           
  Lines      22467   22467           
=====================================
  Hits       17897   17897           
  Misses      4570    4570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 732b938 into open-telemetry:main Jan 30, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants